compiletest: error emitter pretty svg tests don't normalize color differences between Windows and Unixes
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.2k
- PR merge metrics
- PR metrics pending
Description
This is the svg snapshots of the same test test/ui/error-emitter/multiline-removal-suggestion.rs (the former is the reference Unix-blessed snapshot, the latter is generated on Windows with //@ only-linux removed), but I believe this fails on Windows because the exact colors chosen are different. I believe this is because there are certain cmd.exe default bright colors which are very hard to read, so we actually pick different colors on purpose.
cc @estebank for FYI: I reasoned about the failure in #134664 incorrectly, I found out today after revisiting #132752, which is a different bug.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the compiletest case test/ui/error-emitter/multiline-removal-suggestion.rs and compare its Unix-blessed SVG snapshot with the Windows-generated snapshot. Trace the snapshot comparison and color-selection behavior to determine where platform-specific color differences should be normalized. Done means the test can run on both platforms without requiring different color snapshots.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100