run-make-support: `assert_dirs_are_equal` traverses symlinks
Open
Nobody has claimed this yet.
A-run-make
C-bug
T-bootstrap
T-compiler
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
assert_dirs_are_equal will try to read the file content behind symlinks, which is not necessarily the desired behavior. Either we should make it configurable, or avoid traversing symlinks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate assert_dirs_are_equal in the run-make-support code and inspect how it handles symlinks. Determine whether the intended behavior should be configurable or should avoid traversing symlinks, then add or update tests covering symlinked directories and verify the full relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100