rust-lang / rust-lang/rust

bootstrap/compiletest: msys2 msys `--skip` filter behaves strangely

Open
#134,226 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest A-test-infra C-enhancement E-hard T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

As I suspected (unfortunately), inside MSYS2 MSYS, the --skip on the exact path does not work (I suspect this is a compiletest problem, not bootstrap). However, MSYS2 MSYS also has several other ./x test-related issues, so this is not worth blocking on MSYS2 problems IMO.

$ ./x test tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs --stage 1 --skip tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs

running 1 tests
.

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18066 filtered out; finished in 97.23ms

Originally posted by @jieyouxu in https://github.com/rust-lang/rust/issues/134209#issuecomment-2539760846

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ./x test entry point and the compiletest handling of --skip, using the exact command and test path shown in the report. Reproduce it inside MSYS2 MSYS, then trace how the exact path is matched; done means --skip excludes tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.