compiletest: improve diagnostics for test suite default outcome expectation
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Remark (for myself): improve this diagnostics when I get to untangling the runtest logic to make it so that test suites explicitly declare their intended default behavior so that the diagnostics here can say e.g. "expected to check-fail, but this didn't fail" or whatever.
Originally posted by @jieyouxu in https://github.com/rust-lang/rust/pull/133813#discussion_r1868302243
E.g. ui tests by default are expected to "check-fail", compare that to the actual test outcome, etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing compiletest's runtest logic and how ui tests determine their default outcome. Compare the declared or inferred expectation with the actual test result, then make the diagnostics identify both, such as an expected check-fail that did not fail; done means the message explains the mismatch clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100