compiletest: `needs-*` directive handling mixes `:` and ` ` name-val/name-comment separator
Open
Nobody has claimed this yet.
A-compiletest
C-bug
E-hard
E-tedious
T-bootstrap
T-compiler
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Remark: I didn't want to adjust how directives accept
:for name-value form vs name-comment form in this PR, so this temporarily accepts//@ needs-target-has-atomic 8,16,ptrbut I want to only accept the colon form in the future.
Originally posted by @jieyouxu in https://github.com/rust-lang/rust/pull/133736#discussion_r1865325663
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating compiletest's parser for needs-* directives, especially needs-target-has-atomic. Check the existing handling of the colon and space separators, then verify that the colon form remains accepted while the space-separated name-value form is no longer accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100