compiletest: normalization replacement strings don't support newlines
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
It will affect every
normalize-header, but since none of those currently have a\nin them, no other tests will be affected (other than the one I'm adding).There is currently no way to a new-line in the replacement string, I tried a bunch of things and just gave up and added this mini logic.
Originally posted by @Urgau in https://github.com/rust-lang/rust/pull/133710#discussion_r1865295125
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating compiletest's handling of normalize- headers and replacement strings. Reproduce the limitation with a replacement containing a newline, then add the mentioned test and verify that newline-containing replacements work without affecting existing normalization tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100