rust-lang / rust-lang/rust

compiletest can explode due to cyclic auxiliaries

Open
#133,580 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest C-bug E-hard S-blocked T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Right now, compiletest does not forbid auxiliaries from declaring each other as auxiliaries, creating a cycle in the auxiliary build graph. This means that, e.g. for aux A requesting aux build of B, aux B can also request aux build of A.

This will eventually kaboom.

I can't find an existing issue for this, tried searching.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating compiletest's auxiliary build-graph handling and trace how one auxiliary requests another. Reproduce the A-to-B-to-A case described in the issue, then verify that cyclic auxiliary declarations no longer cause compiletest to explode and that coverage exists for the cycle.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.