Use `git diff --no-index` as the default diff in compiletest
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Since not long ago, compiletest supports custom diffing tools in the config.
This is cool, but in practice probably not very used since it requires configuring it.
I think that compiletest should, when git is available, use git diff --no-index by default as the diff.
The default git diff is quite OK, and many people (me included) configure git to have an even prettier one. This way, people get a nice diff by default without configuring anything.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating compiletest's diff-tool configuration and the entry point that selects the default diff command. Check how custom diff tools and git availability are currently handled. Done means git diff --no-index is selected by default when git is available, while explicitly configured diff tools continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, rust
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100