rust-lang / rust-lang/rust

No way to disable tests for `*-windows-gnu` but keep them enabled for `*-windows-gnullvm`

Open
#132,278 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest C-bug E-hard O-windows T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

If I write:

//@ only-windows
//@ ignore-windows-gnu // or just ignore-gnu

Then gnullvm will be also excluded. There are few things (like CFGuad) that will probably never work with mingw-w64+GNU targets but are supported on mingw-w64+LLVM (not yet within Rust).
Using //@ only-windows-gnullvm won't be an option because it would disable the test for *-windows-msvc.

One idea I can think of is to add $ character that means end of the line, just like in regex. So //@ ignore-windows-gnu$ would skip all *-windows-gnu targets from the given test but keep *-windows-gnullvm targets.

Originally posted by @mati865 in #128602
cc @jieyouxu

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how only-windows and ignore-windows-gnu directives match target triples, then inspect the existing test-directive handling and related tests. Done means tests can be excluded for *-windows-gnu while remaining enabled for *-windows-gnullvm and *-windows-msvc, without changing current matching behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.