rust-lang / rust-lang/rust

Github sometimes closes issues that have been re-opened

Open
#130,817 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-meta T-infra
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

When a commit contains the magic words Fixes #xxx, if that commit gets pushed to a repo by someone with permissions to close rust-lang issues, the issue will be closed. (I don't know the exact requirements, but it's something like this.) When a PR has these magic words in the PR description, that gets added to the merge commit message, and causes the same issue. This can lead to accidental issue closure when such a commit gets merged into our repo, then the issue gets reopened, and then the commit gets pushed somewhere.

I've seen this a few times over the last years. The most recent one is https://github.com/rust-lang/rust/issues/102048.

@rust-lang/infra is there anything we can do here? Like disable the "auto close based on commit message" feature (but keep it for PR descriptions!)? If not, maybe this could be added to the wishlist for the next meeting you have with Github people.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the reported example in issue #102048 and the GitHub behavior described for commit messages, merged pull requests, and reopened issues. Determine whether repository settings can disable closure from commit messages while preserving PR-description behavior; done means documenting a confirmed configuration or the limitation and next action.

Written by the indexing model from the issue text.

Assessment

Tech stack
github
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.