rust-lang / rust-lang/rust

incorrect revision syntax is silently accepted

Open
#130,815 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest C-enhancement T-bootstrap
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

https://github.com/rust-lang/rust/blob/1b5aa96d6016bafe50e071b45d4d2e3c90fd766f/tests/ui/traits/coherence-alias-hang.rs#L1-L5

This test never actually tests the new solver. It has to be //@[next] compile-flags: -Znext-solver. We should lint here ✨

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/ui/traits/coherence-alias-hang.rs lines 1–5, referenced by the issue, and inspect how its revision syntax and compile flags are handled. Run the referenced UI test after making the change; done means the incorrect revision syntax is no longer silently accepted and the test uses the intended next-solver configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.