build/bootstrap/.last-warned-change-id gets removed by workaround for #125578
Open
Nobody has claimed this yet.
C-bug
T-bootstrap
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
bootstrap.py contains this snippet:
# FIXME: A cheap workaround for https://github.com/rust-lang/rust/issues/125578,
# remove this once the issue is closed.
bootstrap_out = self.bootstrap_out()
if os.path.exists(bootstrap_out):
shutil.rmtree(bootstrap_out)
p.map(unpack_component, tarballs_download_info)
when updating to a new master, bootstrap gets rebuilt, causing the "last warned change id" file to be deleted, so you see all the "new changes to x.py", even if there are no new changes to x.py.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in bootstrap.py at the workaround for Rust issue #125578 and inspect how build/bootstrap/.last-warned-change-id is handled when bootstrap_out is removed. Reproduce an update to a new master and verify that the warning state is preserved, so unchanged files are not reported as having new changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100