32-bit ARM NEON intrinsics are unsound due to subnormal flushing
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
This is the ARM NEON version of https://github.com/rust-lang/rust/issues/114479. Example by @beetrees, to be compiled with --target armv7-unknown-linux-gnueabihf -O -Ctarget-feature=+neon:
#![feature(stdarch_arm_neon_intrinsics)]
use std::arch::arm::{float32x2_t, vadd_f32};
use std::mem::transmute;
#[inline(never)]
fn print_vals(x: float32x2_t, i: usize, vals_i: u32) {
println!("x={x:?} i={i} vals[i]={vals_i}");
}
const ZERO: float32x2_t = unsafe { transmute([0, 0]) };
const INC: float32x2_t = unsafe { transmute([f32::MIN_POSITIVE / 128.0, f32::MIN_POSITIVE / 128.0]) };
const TARGET: [u32; 2] = unsafe { transmute([f32::MIN_POSITIVE, f32::MIN_POSITIVE]) };
#[inline(never)]
pub fn evil(vals: &[u32; 300]) {
let mut x: float32x2_t = ZERO;
let mut i: usize = 0;
while unsafe { transmute::<float32x2_t, [u32; 2]>(x) } != TARGET {
print_vals(x, i, vals[i]);
x = unsafe { vadd_f32(x, INC) };
x = unsafe { vadd_f32(x, INC) };
i += 2;
}
}
pub fn main() {
let mut vals: [u32; 300] = [0; 300];
for i in 0..300 { vals[i as usize] = i; }
evil(&vals);
}
#[cfg(not(target_feature = "neon"))]
compile_error!("-Ctarget-feature=+neon required");
LLVM's optimizations assume they can calculate what that loop does, and that it follows IEEE semantics. But LLVM's codegen produces code that does not have IEEE semantics, and instead flushes subnormals to zero. 💥
This almost surely also affects the unstable std::simd on ARM.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied ARMv7 reproduction using --target armv7-unknown-linux-gnueabihf -O -Ctarget-feature=+neon, then compare the std::arch::arm::vadd_f32 behavior with the related issue #114479. Read the LLVM optimization and codegen assumptions involved in subnormal handling, including the possible std::simd impact. Done means the reproduction no longer exposes unsound IEEE-semantic behavior on 32-bit ARM NEON.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100