rust-lang / rust-lang/rust

compiletest: test suites handle normalizations differently and inconsistently

Open
#128,952 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-compiletest A-docs C-cleanup E-hard E-needs-design E-needs-investigation T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

Noticed in https://github.com/rust-lang/rust/pull/128929#discussion_r1712861343.

Some test suites use normalize_output when error format is JSON, some test suites do a bit of their own normalization with custom rules, and what we end up with is likely some duplicate logic and subtle inconsistencies. We should probably have e.g. paths normalized consistently across test suites, and document the suite-specific normalizations.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked pull request discussion and inspect compiletest's test suites, including uses of normalize_output and suite-specific normalization rules. Compare how paths and other output are normalized across suites. Done means the normalization behavior is consistent where appropriate and suite-specific differences are documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.