rust-lang / rust-lang/rust

run-make: vendor cargo dependencies or external dependencies within the tests

Open
#128,733 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-run-make A-testsuite C-bug T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

  • tests/run-make/thumb-none-qemu
  • tests/run-make/x86_64-fortanix-unknown-sgx-lvi
  • tests/run-make/thumb-none-cortex-m (uses git clone too)

These tests use cargo to build crates but they have external dependencies -- this makes their pass/fail status conditioned on internet connectivity which does not seem ideal (and also if it's not pinned and it can become awkward from breakages..)

We should investigate if we could vendor the external deps or otherwise make them locally available to make the test outcomes more reproducible.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the three listed tests: tests/run-make/thumb-none-qemu, tests/run-make/x86_64-fortanix-unknown-sgx-lvi, and tests/run-make/thumb-none-cortex-m. Check how each invokes cargo or git clone and identify the external dependencies that affect reproducibility. Done means the tests can obtain their dependencies locally or from vendored sources without relying on internet connectivity.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.