Effective breakage to `jiff` due to `ambiguous_negative_literals`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
We should discuss this bit of evidence that came in after the FCP completed on:
@BurntSushi said:
This completely broke Jiff once the change landed. Because it specifically supports negating spans like
-1.hour(). In the case of Jiff, there is no ambiguity because-1.hour()and(-1).hour()and-(1.hour())are all precisely equivalent.
cc @BurntSushi @rust-lang/lang
@rustbot labels +T-lang +I-lang-nominated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Rust pull request #121364 and the linked discussion about ambiguous_negative_literals, then review the cited Jiff negative-spans documentation. The issue currently asks for discussion of the breakage rather than naming a specific code change or test, so the desired outcome is not defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100