compiletest: don't silently accept unsupported directives in test suites
Open
Nobody has claimed this yet.
A-compiletest
A-contributor-roadblock
C-cleanup
E-hard
T-bootstrap
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Yes, there are special handling here and there for specific directives. But the handling is limited and is only for specific directives in specific test suites.
We should error if a test writer specifies a directive invalid for a given test suite.
This may require reworking how directives are handled, i.e. have test suites "register" what directives they support.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading compiletest's directive handling and tracing how directives are interpreted for each test suite. The change is done when unsupported directives produce errors for the relevant suite while existing supported directives continue to work, with coverage for invalid directives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100