VecDeque::split_off has unexpectedly poor performance characteristics when splitting off from the front.
Open
Nobody has claimed this yet.
C-bug
I-slow
T-libs
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
I tried this code:
use std::collections::VecDeque;
fn huge_queue() -> VecDeque<usize> {
const HUGE: usize = 1000000;
let mut queue = VecDeque::with_capacity(HUGE);
for i in 0..HUGE {
queue.push_back(i);
}
queue
}
const CHUNK: usize = 123;
const FAST: bool = false;
fn main() {
let mut queue = huge_queue();
if FAST {
while queue.len() > CHUNK {
queue.rotate_left(CHUNK);
let rest = queue.split_off(queue.len() - CHUNK);
println!("Chunk of {}", rest.len());
}
} else {
while queue.len() > CHUNK {
let rest = queue.split_off(CHUNK);
println!("Chunk of {}", queue.len());
queue = rest;
}
}
println!("Remaining: {}", queue.len());
}
I expected the FAST branch and the else branch to have comparable performance, instead it seems VecDeque::split_off from the front is much slower than expected (as one would expect of e.g. Vec::split_off which needs to shift all the elements).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names VecDeque::split_off but no source file or test. Start by running the provided Rust reproduction and comparing the FAST and else branches, then trace the split_off implementation; done means front splitting no longer has the reported unexpectedly poor performance while preserving the demonstrated behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100