rust-lang / rust-lang/rust

Binary size creep on Fuchsia after commit 5ced3da

Open
#127,039 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-optimization E-needs-mcve I-heavy O-fuchsia T-compiler
Dominant language
Rust
Stars
119k
Forks
16.2k
PR merge metrics
PR metrics pending

Description

After bors rolled commit 5ced3da, Fuchsia's canaries began failing their binary size creep checks. See attached screenshot. It's non-obvious why this change would impact codegen on Fuchsia, but I wanted to alert the rust-lang project and commit author that this has occurred.

Screenshot 2024-06-27 at 10 14 40 AM

cc: @tesuji @erickt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting commit 5ced3da and the Fuchsia canary binary-size creep results referenced in the issue. Determine which change caused the size increase and verify the fix against the affected canary checks; done means the regression is explained and Fuchsia binary-size checks pass again.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.