Several tests with `//@ needs-force-clang-based-tests` don't seem to run anywhere
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
(Follow-up to #126180 and #126257.)
There are currently 5 tests that use the needs-force-clang-based-tests header (formerly needs-matching-clang):
tests/run-make/cross-lang-lto-clang/Makefile(this one does actually run)tests/run-make/cross-lang-lto-pgo-smoketest/Makefiletests/run-make/cross-lang-lto-riscv-abi/rmake.rstests/run-make/issue-84395-lto-embed-bitcode/Makefiletests/run-make/wasm-override-linker/Makefile
Tests with this header only run when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set. That environment variable is only set in the x86_64-gnu-debug job, and only when running x --stage 2 test tests/run-make --test-args clang. So in practice, 4/5 of the above tests don't appear to ever run in any CI job.
@rustbot label +A-testsuite
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the five listed Makefile and rmake.rs entries and the x86_64-gnu-debug invocation that sets RUSTBUILD_FORCE_CLANG_BASED_TESTS. Compare the four tests that do not run with cross-lang-lto-clang, then verify the affected run-make tests execute in an appropriate CI job.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100