compiletest: more consistent handling of bool-like env vars
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Noticed in https://github.com/rust-lang/rust/pull/125890#issuecomment-2143875898.
It would be nice to have more consistent handling of what is considered "truthy" or "falsey" for env vars that accept a bool-ish value. In particular, if an env var's value contains invalid UTF-8, we probably should straight up error instead of silently parsing it as truthy/falsey?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with compiletest's handling of environment variables and read the discussion in rust-lang/rust#125890, especially the linked issue comment. Inventory the bool-like values and invalid UTF-8 cases involved, then establish consistent parsing and error behavior with tests covering the agreed cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100