Tracking issue for migrating from Glacier to compiletest ICE/crash tracking
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.1k
- PR merge metrics
- PR metrics pending
Description
Tracks the necessary steps to "fully"[^1] transition from rust-lang/glacier to compiletest ICE/crash tracking inside tests/crashes/.
See also this Zulip topic.
Steps
- Implement
rustcICE/crash tracking: #122997 - Implement
rustdocICE/crash tracking -
Implement(questionable)rustfmtICE/crash tracking - Implement ICE/crash tracking via
run-make/rmake(to supersede Glacier's shell scripts) - Archive rust-lang/glacier: rust-lang/team#1459
- Sunset triagebot support for Glacier
- Update the rustc-dev-guide: https://github.com/rust-lang/rustc-dev-guide/pull/2413
- Remove mentions of Glacier
- Add small section about
tests/crashes/: Overview, rough procedure (adding//@ known-bug, https://github.com/rust-lang/rust/labels/S-bug-has-test) - https://github.com/rust-lang/rustc-dev-guide/pull/2588
- Mention
tests/crashes/in places where we reference https://github.com/rust-lang/rust/labels/E-needs-test (EDIT(fmease): What did I mean by this?)
- Update the Rust Forge
- Remove mentions of Glacier (namely the triagebot section): https://github.com/rust-lang/rust-forge/pull/856
- Maybe mention the new system in the issue triaging chapter (EDIT(fmease): The Forge, really?)
- If technically feasible, add a CI check that a PR fixing crash tests mentions all fixed issues via GH auto-close keywords like Fixes to prevent the accumulation of "ghost issues". EDIT(fmease): triagebot nowadays posts a general message if
tests/crashes/has been modified. Doesn't that suffice?
Unresolved Questions
- Should we implement
rustdocsupport via subdirectories/tests suites (e.g.,tests/crashes/rustdoc/) or via a new compiletest directive (e.g.,//@ bin: rustdoc)- If we do the former, should we move
rustctests fromtests/crashes/totests/crashes/rustc/?
- If we do the former, should we move
- Should we define precise procedures for adding new tests to
tests/crashes?
[^1]: Glacier|_{rust-lang/rust}, i.e., restriction of Glacier to rust-lang/rust (excluding git submodules/subtrees), i.e., Glacier without support for rustfmt, Cargo, Clippy, Miri ICE/crash tracking
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the remaining checklist items for tests/crashes/, especially rustdoc ICE/crash tracking, run-make/rmake support, and the Rust Forge issue-triaging chapter. Resolve the documented questions about rustdoc subdirectories versus a compiletest directive and procedures for adding tests. Done means the remaining migration steps are completed or explicitly decided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100