rust-lang / rust-lang/rust

Enabling internal lints shouldn't be dependent on `-Zunstable-options`

Open
#122,897 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lints C-discussion T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

We currently enable internal lints only if -Zunstable-options is passed:

https://github.com/rust-lang/rust/blob/1447f9d38ca388ca178a544534b3cff72945fa1e/compiler/rustc_session/src/session.rs#L344-L349

This behavior is surprising at least, and seems wrong. Should we move this to some -Zenable-internal-lints or something?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading compiler/rustc_session/src/session.rs around the linked lines to understand how internal lints are currently enabled and how -Zunstable-options affects that decision. Trace the relevant option handling and determine the intended independent control for internal lints. Done means the dependency on -Zunstable-options is addressed with the project’s chosen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.