rust-lang / rust-lang/rust

ICE due to renaming type (`ParseError` -> `ParseDiagnostic`)

Open
#119,728 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-incr-comp C-bug I-ICE T-compiler
Dominant language
Rust
Stars
119k
Forks
16.1k
PR merge metrics
PR metrics pending

Description

This was not the compiler error I was expecting while working on my hobby language 😅 .

Code

You can find the exact commit here. Sorry, I couldn't make a minimal repro. I tried and the error was occurring, then it magically stopped. I have no clue why. I'll give it another shot later. Repro here

I narrowed the cause down to renaming ParseError to ParseDiagnostic. If I rename it back, the ICE goes away.

Meta

rustc --version --verbose:

rustc 1.75.0 (82e1608df 2023-12-21)
binary: rustc
commit-hash: 82e1608dfa6e0b5569232559e3d385fea5a93112
commit-date: 2023-12-21
host: aarch64-apple-darwin
release: 1.75.0
LLVM version: 17.0.6
Error output

here

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked rust-ice-repro repository and reproduce the ICE using the reported rustc 1.75.0 toolchain. Compare the behavior when ParseError is renamed to ParseDiagnostic and inspect the linked error output and original commit. Done means the rename no longer triggers an internal compiler error, with regression coverage for the reproducer.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.