Remove duplicate diagnostics introduced by #119432
Open
Nobody has claimed this yet.
A-const-eval
A-const-prop
A-diagnostics
C-cleanup
T-compiler
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.2k
- PR merge metrics
- PR metrics pending
Description
A side effect of #119432 is that some overflowing operations on promoted consts now create duplicate diagnostics. Although not visible to the user, they are unnecessary and need to be addressed. See relevant conversation: https://github.com/rust-lang/rust/pull/119432#discussion_r1443161280
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the relevant conversation in PR #119432, especially discussion_r1443161280, to understand how promoted consts are involved. Reproduce an overflowing operation on a promoted const and trace where the duplicate diagnostics are produced. Done means the operation emits only the necessary diagnostic without changing user-visible behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100