consider bannig empty `panic`/`unreachable`/ `bug`s from rustc codebase
Open
Nobody has claimed this yet.
A-contributor-roadblock
A-meta
C-cleanup
T-compiler
- Dominant language
- Rust
- Stars
- 119k
- Forks
- 16.2k
- PR merge metrics
- PR metrics pending
Description
git grep "[^e]bug\!()" compiler 130
git grep "panic\!()" compiler 43
git grep "unreachable\!()" compiler 384
I wonder if it makes sense to try to fill these up with at least somewhat contextual error/ice messages instead of just a "panicked at" or "impossible case reached"?
Unfortunately I could not find a rustc lint that warns on empty panics like these
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the compiler results from the listed git grep searches for empty bug!(), panic!(), and unreachable!() calls. Determine which cases need contextual ICE messages and establish a scope and completion criteria; the issue does not name specific files, tests, or a defined set of cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100