rust-lang / rust-lang/rust-mode

Use rustic changes that have not been applied to rust-mode.el

Open
#421 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Emacs Lisp
Stars
1.3k
Forks
198
PR merge metrics
No merged PRs in 30d

Description

Recently rustic was changed to use rust-mode as dependency. Some new code in the former rustic.el was not moved to rust-mode.e(#407). We should merge those improvements:

  • improved regexes in rustic-top-item-beg-re
  • include keyword existential in rust-keywords
  • performance improvements for rust-syntax-propertize functions (@phillord would be great if you could take a look)
  • tests that are not present in rust-mode

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the former rustic.el changes with rust-mode.el, focusing first on the unchecked rust-syntax-propertize performance work. Then identify tests that existed in rustic but are absent from rust-mode and add coverage for the merged behavior. Done means the improvements are present in rust-mode.el and the missing tests cover them.

Written by the indexing model from the issue text.

Assessment

Tech stack
emacs-lisp
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.