rust-lang / rust-lang/rust-mode

Bitwise shift operator breaks indentation rules

Open
#398 7 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted indentation
Dominant language
Emacs Lisp
Stars
1.3k
Forks
198
PR merge metrics
No merged PRs in 30d

Description

When I let Emacs indent this code, it assumes the bitwise shift operator is an opening angle bracket.

let a = u32::MAX << 5;

The issue is caused by the column characters, I personally think rust-is-lt-char-operator doesn't handle this special case.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating rust-is-lt-char-operator and reproduce the indentation behavior with let a = u32::MAX << 5;. Trace how the two shift characters are classified during indentation, then verify that the expression is indented as a bitwise shift rather than as an opening angle bracket.

Written by the indexing model from the issue text.

Assessment

Tech stack
emacs-lisp, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.