rust-lang / rust-lang/rust-clippy

detect unnecessary curly braces

Open
#9,974 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

In the following example, there's a single expression inside curly braces. I think clippy should detect that because it is probably not intended. (We have some of these in our codebase due to refactor.)

Lint Name

unecessary_curly_braces

Category

style

Advantage
  • Remove lines of code
  • Removes indentation
  • (Improves readability)
Drawbacks

No response

Example
let a = {
  if cond {
    None
  } else {
    Some(5)
  }
};

Better:

let a = if cond {
  None
} else {
  Some(5)
};

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Clippy's lint entry points and tests for style lints, then inspect how expression-level curly braces are represented and tested. Use the issue's let a examples as the baseline and verify that the unnecessary outer braces are detected while the braces inside the if expression remain valid. Done means the lint and regression coverage handle this case without false positives.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.