rust-lang / rust-lang/rust-clippy

new lint: duplicate pattern match

Open
#9,968 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

see example

Lint Name

duplicate_pattern_match (TODO: we need a better name)

Category

style

Advantage

cleaner code
easy to understand

Drawbacks

Seldom to meet such strange code

Example
let (x | x) = 1;
let (x | x | x) = 1;
let (x | x | x | x) = 1;

Could be written as:

let x = 1;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files, tests, or entry points are named. Start by reviewing the Rust examples in the issue and locating comparable Clippy pattern-match lints. Done means the proposed lint is implemented for repeated alternatives such as x | x, with coverage for the shown cases and a clear lint name.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.