rust-lang / rust-lang/rust-clippy
`cargo uitest` fails when project path has whitespaces
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Summary
calling cargo uitest when rust-clippy's path has whitespaces makes all tests fail. for example, if rust-clippy's path is C:\rust whitespace\rust-clippy, it will emit the following for every test (test_name):
error: multiple input filenames provided (first two filenames are `tests\\ui\\test_name.rs` and `whitespace\\rust-clippy\\target\\debug\\deps`
(notice the second path is incomplete and begins right after the whitespace in the full path)
putting rust-clippy somewhere with no whitespaces on it's path solves the issue (however, a cargo clean seems to be necessary for it do so, for some reason).
Reproducer
I tried: calling cargo uitest.
I expected to see this happen: tests run correctly.
Instead, this happened: all tests fail with the aforementioned error as their output.
Version
rustc 1.66.0-nightly (4b8f43199 2022-10-19)
binary: rustc
commit-hash: 4b8f4319954ff2642690b9e5cbe4af352d095bf6
commit-date: 2022-10-19
host: x86_64-pc-windows-msvc
release: 1.66.0-nightly
LLVM version: 15.0.2
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the cargo uitest implementation and reproduce the failure on Windows using a rust-clippy path containing whitespace. Check how the path is passed to each test invocation; done means cargo uitest runs the UI tests successfully from a whitespace-containing path without the reported multiple-input-filenames error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100