rust-lang / rust-lang/rust-clippy
Prefer X.floor() instead of FP::floor(x)
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Suggests a better pattern of code.
Lint Name
direct_method_call
Category
pedantic
Advantage
More dry, shorter.
Drawbacks
No response
Example
A pattern I've seen in code:
let y = f64::floor(x as f64);
I think it's better written:
let y = (x as f64).floor();
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing direct_method_call lint in the rust-clippy repository and review how similar method-call suggestions are implemented and tested. Add coverage for the f64::floor(x as f64) pattern and verify that the suggested (x as f64).floor() form is emitted without affecting unrelated code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100