Avoid using Option::take when ownership could be transferred

What it does

Lint on usages of Option::take when ownership can be transferred anyway.

See also needless_option_take

Lint Name

needless_owned_option_take

Category

complexity

Advantage

Shorter code, potentially reduced number of mut keywords.

Drawbacks

No response

Example

let mut x = Some(42);
if let Some(v) = x.take() {
    dbg!(v);
}

Could be written as:

let x = Some(42);
if let Some(v) = x {
    dbg!(v);
}

Start by reviewing the existing needless_option_take lint linked in the issue and the surrounding Clippy lint implementation. Confirm the new lint recognizes cases where Option ownership can be transferred without take, while preserving the shown behavior and avoiding false positives; add or update the corresponding lint tests once their location is identified.