rust-lang / rust-lang/rust-clippy
Clippy should warn about unnecessary `#[inline]` attributes
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Generic functions already allow cross-crate inlining, so clippy should warn about marking one of these functions with #[inline]`.
Lint Name
unnecessary_inline
Category
style
Advantage
Code is less noisy.
Drawbacks
Some users may prefer to use the inline attribute even when it is redundant.
Example
#[inline]
fn identity<T>(x: T) { ... }
Could be written as:
fn identity<T>(x: T) { ... }
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation and tests for the proposed unnecessary_inline lint in rust-clippy. Use the generic identity<T> example as the initial case, and consider the work complete when redundant #[inline] attributes are diagnosed without warning on functions where the attribute is not redundant.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100