rust-lang / rust-lang/rust-clippy
Faster release cadence for bug fixes to stable
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
In my projects I upgrade to the latest Rust toolchain quickly after release. It is fairly common to have to work around bugs in clippy as part of this process. From browsing the issue tracker, false positives and bad suggestions tend to get reported in batched when a new stable compiler hits.
Here are some such issues that I have filed or been interested in:
- https://github.com/rust-lang/rust-clippy/pull/5998#issuecomment-731855891
- https://github.com/rust-lang/rust-clippy/issues/6137
- https://github.com/rust-lang/rust-clippy/issues/6739
- https://github.com/rust-lang/rust-clippy/issues/6970
- https://github.com/rust-lang/rust-clippy/issues/7567
- https://github.com/rust-lang/rust-clippy/pull/7568
- https://github.com/rust-lang/rust-clippy/issues/8120
- https://github.com/rust-lang/rust-clippy/issues/8281
- https://github.com/rust-lang/rust-clippy/issues/8300
- https://github.com/rust-lang/rust-clippy/issues/8470
- https://github.com/rust-lang/rust-clippy/issues/9321
- Lots of
manual_let_elsebreakage - https://github.com/rust-lang/rust-clippy/pull/10442
I love that clippy has a wide selection of lints, but the reality is some of them are buggy when they get released. Even if I report a bug the day a stable compiler comes out, it takes at least 12 weeks for fixes to roll out (for fixes to go through a full nightly to beta to stable cycle).
Is there a way to roll out fixes for false positives and bugs in stable clippy more quickly?
I've previously expressed concerns about buggy lints making it to stable in https://github.com/rust-lang/rust-clippy/pull/5998#issuecomment-731855891 where I proposed running new lints through something like a crater run. After thinking about it, I think what I'd actually like to see is bug fixes be released in a more rapid manner than they are today.
I've also previously asked if clippy bugs getting fixes would warrant a point release to the stable Rust toolchain. I'm not sure what the team's thinking on this is.
Version
rustc 1.63.0 (4b91a6ea7 2022-08-08)
binary: rustc
commit-hash: 4b91a6ea7258a947e59c6522cd5898e7c0a6a88f
commit-date: 2022-08-08
host: x86_64-apple-darwin
release: 1.63.0
LLVM version: 14.0.5
Additional Labels
@rustbot label +C-question
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to prior Clippy issues and pull requests, but names no files, tests, or implementation entry point. Start by reviewing the linked discussions and the project's stable-release process; done would require an agreed, documented way to deliver stable Clippy bug fixes faster.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100