rust-lang / rust-lang/rust-clippy
Warn about using `bool::then_some` followed by `unwrap_or`, suggest `if`/`else` instead
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Detects the combination of then_some followed by unwrap_or in place of a more clear if/else.
Lint Name
bool_if_else
Category
style
Advantage
- Clarity at a glance
Drawbacks
No response
Example
let mode = executable.then_some(IsExecutable).unwrap_or(IsNotExecutable);
Could be written as:
let mode = if executable { IsExecutable } else { IsNotExecutable };
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search rust-clippy for the bool_if_else lint and its tests, then compare the then_some().unwrap_or() pattern with the issue's examples. Done means the lint detects this pattern, recommends if/else, and includes coverage for the shown behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100