rust-lang / rust-lang/rust-clippy

`ptr_arg` false negative when `IntoIterator` is used

Open
#8,995 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug I-false-negative
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Summary

When the IntoIterator impl of a &Vec is used the lint doesn't fire

Lint Name

ptr_arg

Reproducer
fn f(x: &Vec<u32>) {
    for _ in x {}
}

playground

Version

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ptr_arg lint and the supplied Rust reproducer, focusing on the IntoIterator use for &Vec. Run the reproducer and inspect the lint's existing tests or implementation to determine why this case is missed. Done means the lint reports the shown function without breaking related ptr_arg behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.