rust-lang / rust-lang/rust-clippy

Unnecessary Vec/VecDeque reserve lint

Open
#8,982 6 comments 2 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Inspired by:
https://github.com/rust-lang/rust/pull/97922

In a basic case like this Clippy could suggest to remove the call to reserve() because it's unnecessary:

Lint Name

unnecessary_reserve

Category

pedantic

Advantage

No response

Drawbacks

No response

Example
fn test1(v: &mut Vec<u32>, b: &[u32]) {
    v.reserve(b.len());
    v.extend(b);
}

The same for VecDeque.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.