rust-lang / rust-lang/rust-clippy

iterating over empty collections

Open
#8,890 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Warn when we iterate over a collection that we know is empty

let v = vec![1,2,3];

if v.is_empty() {
  v.iter()....
}

maybe the condition was supposed to be inverted?

Lint Name

maybe iter_empty ?

Category

suspicious

Advantage

No response

Drawbacks

No response

Example

see above

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named; begin by locating Clippy's suspicious-lint implementations and their UI tests. Clarify the intended lint name and what counts as a provably empty collection, then define completion as a warning and regression coverage for the shown pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.