rust-lang / rust-lang/rust-clippy
Lint suggestion: Path construction using format!
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Suggest to create PathBufs using Path::join (or maybe PathBuf::push in some circumstances) instead of string formatting.
Lint Name
path_format
Category
suspicious
Example
PathBuf::from(format!("{}/foo/bar", base_path)); // or
PathBuf::from(format!("{}\\foo\\bar", base_ath));
could be written as
Path::new(base_path).join("foo").join("bar")
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the rust-clippy repository by locating the implementation and tests for the path_format lint, then review how existing suspicious lints construct suggestions. Confirm the lint handles the shown PathBuf::from(format!(...)) examples and produces Path::join or PathBuf::push suggestions without incorrect path assumptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100