rust-lang / rust-lang/rust-clippy

unnecessary_move lint, removing move with no effect

Open
#8,751 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

clippy reports no warnings for unnecessary move keyword, such as:

let closure = move || value_moved(v);

Here move is unnecessary since there's no reference capture.

If a lint for above is acceptable, we may also have some warnings for belows.

std::thread::spawn(move || { value_moved(v) }

or

tokio::spawn(async move || value_moved_async(v).await})
Lint Name

unnecessary_move

Category

style

Advantage
  • Brings minimalism.
Drawbacks

No response

Example
move || value_moved(v);

Could be written as:

|| value_moved(v);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation file or test is named. First review existing Clippy lint implementations and tests for closure captures, then determine whether the proposed cases are valid and how the lint should handle closures passed to spawning APIs. Done means an accepted scope, diagnostics for the supported examples, and tests covering the chosen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.