rust-lang / rust-lang/rust-clippy
lint spurious searches
Open
Nobody has claimed this yet.
A-lint
E-medium
L-style
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
iter loops that set a variable to the current element based on an equality check, but do not break, suggest .iter().find(..) or .iter().rev().find(..), e.g.
let mut found = None;
for x in xs {
if x == f {
found = Some(x);
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the issue's example of an iter loop that assigns the current element after an equality check without breaking. Determine the supported cases and whether the lint should suggest .iter().find(..) or .iter().rev().find(..); done means the intended pattern is diagnosed without incorrect suggestions and covered by appropriate lint tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100