rust-lang / rust-lang/rust-clippy
lint lints that lint spans of different nodes than those currently visited
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
The way the *LintPass traits are structured, the #[allow(..)], #[warn(..)], #[deny(..)] annotations only are set within the check_* callback for the respective portion of the code. As such, finding a span_lint with a span that does not come from the currently visited node (e.g. Expr) should raise a warning.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the *LintPass trait callbacks and the span_lint call sites involved in linting spans from nodes other than the currently visited node. Determine the intended warning behavior and its scope before making a change; done means such mismatched spans are detected consistently without disrupting valid lint spans.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100