rust-lang / rust-lang/rust-clippy

warn about shadowed format args?

Open
#8,589 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Warn about format args that declared for the same format string.

#![warn(clippy::shadow_reuse, clippy::shadow_same, clippy::shadow_unrelated)]
pub fn main() {
    let x = 2;
    println!("{x} {y}", x = x*x, y=x);
}

one might think that this could print 4 4 but it will actually print 4 2 because the y=x binding binds the let x variable and not the x =x*x that we declared in the format string previously

Lint Name

shadow_format maybe?

Category

style

Advantage

No response

Drawbacks

No response

Example
#![warn(clippy::shadow_reuse, clippy::shadow_same, clippy::shadow_unrelated)]
pub fn main() {
    let x = 2;
    println!("{x} {y}", x = x*x, y=x);
}

Could be written as:

#![warn(clippy::shadow_reuse, clippy::shadow_same, clippy::shadow_unrelated)]
pub fn main() {
    let x = 2;
    println!("{z} {y}", z = x*x, y=x);
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by reviewing how rust-clippy defines format-related lints and compare the supplied println! example with its suggested rewrite. Done means the proposed shadowed-format-argument case is detected and the example is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.