rust-lang / rust-lang/rust-clippy

`disallowed_methods` on trait impls

Open
#8,581 6 comments 31 reactions 1 assignee View on GitHub

@DevAccentor is already working on this.

Since Jun 5, 2022.

C-enhancement E-medium
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Description

It should be possible to to specify a specific impl of a trait method (e.g. <alloc::vec::Vec as core::iter::IntoIterator>::into_iter) to be disallowed, rather than having to disallow the trait method for all impls. Two things will need to be done to fix this:

  • clippy.toml syntax will need to be extended.
  • The DefId for the trait method will need to be resolved to it's impl's DefId, if possible (generic code will need something more creative here as it could be calling <T as IntoIterator>::into_iter).

@rustbot label +E-medium
@rustbot label +C-enhancement

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.