rust-lang / rust-lang/rust-clippy
Warn about struct patterns being used as a replacement for variable types
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Warns about code like let a @ Vec { .. } = todo!();. See https://users.rust-lang.org/t/dont-like-avoid-it-with-this-one-weird-trick/71639?u=xfix for example of such code.
Lint Name
No response
Category
style
Advantage
Uses a more usual style which is less confusing.
Drawbacks
None.
Example
fn main() {
let v @ Vec { .. } = (1..10).collect();
dbg!(v);
}
Could be written as:
fn main() {
let v: Vec<_> = (1..10).collect();
dbg!(v);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the Rust example in the issue as the starting case, and compare the proposed let v: Vec<_> form with the let v @ Vec { .. } form. Review existing Rust Clippy style-lint entry points and tests to determine how this warning should be represented; done means the pattern is diagnosed while the conventional type annotation remains accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100