rust-lang / rust-lang/rust-clippy
False positive on `enum_clike_unportable_variant`
Open
Nobody has claimed this yet.
C-enhancement
E-medium
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
x = 1isize << 31;
is okay as long as the specific bit pattern is of the essence; the actual value may vary.
E.g. see https://github.com/ledbettj/wavefile/blob/master/src/speakers.rs#L20
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the enum_clike_unportable_variant lint and reproduce it with the issue's 1isize << 31 example. Compare it with the linked wavefile example at src/speakers.rs#L20; done means this valid bit-pattern use is no longer reported, with a regression test covering it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100