rust-lang / rust-lang/rust-clippy
[ER] Useless slicing warning
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Inspired by this issue:
https://github.com/rust-lang/rust/pull/91625
In code like this:
fn main() {
let s = "abc".to_string();
let t = s.strip_prefix(&['a', 'x'][..]);
println!("{:?}", t);
}
Clippy could suggest to write instead:
s.strip_prefix(&['a', 'x'])
Or even:
s.strip_prefix(['a', 'x'])
Lint Name
No response
Category
No response
Advantage
No response
Drawbacks
No response
Example
<code>
Could be written as:
<code>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked Rust pull request 91625 and Clippy's existing lint implementations and UI tests for similar slice suggestions. Add coverage for the shown strip_prefix patterns and verify that the lint suggests removing the unnecessary slice, including the form without an explicit reference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100