rust-lang / rust-lang/rust-clippy
Should we lint things that would get fixed by rustfmt anyway?
Open
Nobody has claimed this yet.
C-question
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
rustfmt would/(will?) reorder the following to move all the uses to the top.
use a::b;
fn bla() {}
use x::y;
We could of course lint on such things, but people might end up having to reconfigure both rustfmt and clippy for their projects, because the one moves something around that clippy then lints about.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the rustfmt ordering example and inspect the relevant Clippy lint behavior and configuration. Determine whether Clippy should lint code that rustfmt would reorder, including whether users would need conflicting rustfmt and Clippy settings; the work is done when that policy and its expected behavior are clearly established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100