rust-lang / rust-lang/rust-clippy

lint nested locks

Open
#779 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium L-unnecessary T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Having a Mutex or RWLock inside a struct that is behind another Mutex or RWLock makes little sense, but could happen because of oversight, macros/type aliases etc. so it makes sense to lint against it.

Example:

struct X {
   l: Mutex<Too>,
   ..
}

let x = Mutex::new(X{ .. });

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating existing Clippy lints that inspect Mutex or RWLock types, then determine how nested locks behind structs, macros, and type aliases are represented; done means the example is diagnosed without inappropriate false positives and has coverage for the relevant cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.